Functions to Get Official MAD Tuples From Only a Playlist String#8
Open
bamesserly wants to merge 4 commits intomainfrom
Open
Functions to Get Official MAD Tuples From Only a Playlist String#8bamesserly wants to merge 4 commits intomainfrom
bamesserly wants to merge 4 commits intomainfrom
Conversation
My idea to use ternary operator to switch between parent CTORs is not allowed. Back to the drawing board.
Going with a function instead. But here are the latest changes for posterity.
Don't extend the class, instead just make a MakeMacroUtil function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new prospective functions
GetPlaylistFileandMakeMacroUtil.Looking ahead to the ultimate MAD production – we'll want a function to just get these tuples. That's
GetPlaylistFile.Originally, I thought we should also make a function to create a MacroUtil object with these official tuples and just a playlist specification, but I've cooled to the idea. The MacroUtil CTORs are spartan as-is, and we can leave it to users to extend them if they want.
As is, I'm not ready to merge to main because the
GetPlaylistFileuses my completely unvalidated p3 playlists. Ideally, a MAD production person would put these playlists together, put them into this repo, and we'd call those. So this is just a stand-in.Additionally, we'll definitely want an analogous python function. I, like I suspect a lot of users, open the playlist file in python, loop over them, and submit grid jobs on each one. So that we'll be a very common use-case.